Skip to content

Conversation

rikba
Copy link
Contributor

@rikba rikba commented Mar 31, 2021

  • Replace tf with tf2_ros
  • Publish static_transform

The last point assumes we use geotf only to transform static coordinate frames.

@rikba rikba requested a review from michaelpantic March 31, 2021 19:54
@rikba
Copy link
Contributor Author

rikba commented Mar 31, 2021

Tested demo.launch and on DJI platform.

Copy link
Member

@michaelpantic michaelpantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! makes a lot of sense.

I had a quick look at Jenkins, it seems to be missing the tf2 depency. Problem is, I can't change the build config (jenkins throws an error). So at some point might need to setup this build newly. Or do you wanna have a look?

@rikba
Copy link
Contributor Author

rikba commented Apr 1, 2021

Thanks, I will have a look.

@Timple
Copy link

Timple commented Aug 19, 2022

Shouldn't Jenkins not simply perform a rosdep install?

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants